remove deprecated dropshadows#815
remove deprecated dropshadows#815AlexVelezLl merged 9 commits intolearningequality:developfrom lokesh-sagi125:dropshadow
Conversation
ozer550
left a comment
ozer550
left a comment
There was a problem hiding this comment.
I just saw that in the issue description it is mentioned rather to comment these out and not remove them completely.
This reverts commit 20bd55c.
|
oh , sorry about that @ozer550 i got confused and thought its the other way around 😅, just reverted the delete and commented the deprecated dropshadows:). |
This reverts commit 00b5e2a.
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thank you @lokesh-sagi125! These are the right changes for this, however, for now, we are checking if these 3 values 1dp, 2dp and 6dp also aligned correctly to Studio's needs, so I will block the merge of this PR for now until we have a final confirmation from our design team 🤗 thank you!
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Alright, it seems that these will work fine with Studio 🎉. Lets just add this comment that was mentioned in the issue,and after that, this should be good to go!
| box-shadow: 0 3px 5px -1px rgba(0, 0, 0, 0.2), 0 5px 8px 0 rgba(0, 0, 0, 0.14), | ||
| 0 1px 14px 0 rgba(0, 0, 0, 0.12); | ||
| } | ||
| // %dropshadow-3dp { |
There was a problem hiding this comment.
Could we add here a comment indicating that uncommenting needs to be discussed with designers and should be aligned with the guidelines.
adding a comment indicating uncommenting needs to be discussed with the designers first
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Hey @lokesh-sagi125! Lets remove these extra additions, and after that we can proceed to merge the PR. Thank you!
This reverts commit 78ca748.
|
@AlexVelezLl just removed the additions |
AlexVelezLl
left a comment
AlexVelezLl
left a comment
There was a problem hiding this comment.
Thank you @lokesh-sagi125! This looks good to me, merging 🎉.
4 participants
Description
remove deprecated dropshadows
Issue addressed
#725
Addresses #725
Changelog